Add std::lock_guard test for spin_lock.

lib/pls/include/pls/internal/base/spin_lock.h

@@ -17,19 +17,8 @@ namespace pls {
             public:
                 spin_lock(): flag_{ATOMIC_FLAG_INIT}, yield_at_tries_{1024} {};
 
-                void lock() {
-                    int tries = 0;
-                    while (flag_.test_and_set(std::memory_order_acquire)) {
-                        tries++;
-                        if (tries % yield_at_tries_ == 0) {
-                            this_thread::yield();
-                        }
-                    }
-                }
-
-                void unlock() {
-                    flag_.clear(std::memory_order_release);
-                }
+                void lock();
+                void unlock();
             };
         }
     }

lib/pls/src/internal/base/spin_lock.cpp

@@ -3,7 +3,19 @@
 namespace pls {
     namespace internal {
         namespace base {
-            // implementation in header (inlining)
+            void spin_lock::lock() {
+                int tries = 0;
+                while (flag_.test_and_set(std::memory_order_acquire)) {
+                    tries++;
+                    if (tries % yield_at_tries_ == 0) {
+                        this_thread::yield();
+                    }
+                }
+            }
+
+            void spin_lock::unlock() {
+                flag_.clear(std::memory_order_release);
+            }
         }
     }
 }

test/base_tests.cpp

@@ -3,6 +3,7 @@
 #include <pls/internal/base/spin_lock.h>
 
 #include <vector>
+#include <mutex>
 
 using namespace pls::internal::base;
 using namespace std;
@@ -33,18 +34,19 @@ TEST_CASE( "thread state", "[internal/base/thread.h]") {
 }
 
 TEST_CASE( "spinlock protects concurrent counter", "[internal/base/spinlock.h]") {
-    constexpr int num_iterations = 1000000;
+    constexpr int num_iterations = 100000;
     int shared_counter = 0;
     spin_lock lock{};
 
-    auto t1 = start_thread([&] () {
+    SECTION( "lock can be used by itself" ) {
+        auto t1 = start_thread([&]() {
             for (int i = 0; i < num_iterations; i++) {
                 lock.lock();
                 shared_counter++;
                 lock.unlock();
             }
         });
-    auto t2 = start_thread([&] () {
+        auto t2 = start_thread([&]() {
             for (int i = 0; i < num_iterations; i++) {
                 lock.lock();
                 shared_counter--;
@@ -56,4 +58,25 @@ TEST_CASE( "spinlock protects concurrent counter", "[internal/base/spinlock.h]")
         t2.join();
 
         REQUIRE(shared_counter == 0);
+    }
+
+    SECTION( "lock can be used with std::lock_guard" ) {
+        auto t1 = start_thread([&]() {
+            for (int i = 0; i < num_iterations; i++) {
+                std::lock_guard<spin_lock> my_lock{lock};
+                shared_counter++;
+            }
+        });
+        auto t2 = start_thread([&]() {
+            for (int i = 0; i < num_iterations; i++) {
+                std::lock_guard<spin_lock> my_lock{lock};
+                shared_counter--;
+            }
+        });
+
+        t1.join();
+        t2.join();
+
+        REQUIRE(shared_counter == 0);
+    }
 }